SE-2989 [LX-716] [SE-3026] [LX-793] add more customizable sections and attachments to case study

labxchange / labxchange-xblocks

XBlocks for LabXchange

Apache License 2.0

2 stars 4 forks source link

SE-2989 [LX-716] [SE-3026] [LX-793] add more customizable sections and attachments to case study #10

Closed samuelallan72 closed 4 years ago

samuelallan72 commented 4 years ago

This is a breaking change to how case studies are structured to support customizable sections, multiple children per section, and inline html text content.

Test instructions:

deploy this branch along with https://gitlab.com/opencraft/client/LabXchange/labxchange-dev/-/merge_requests/934
follow test instructions with the labxchange PR

Reviewers:

[x] @s0b0lev
[x] @bradenmacdonald or @symbolist may wish to sign off on this too

symbolist commented 4 years ago

@swalladge The changes look good; can do a final pass once the UI is implemented. 🙂

samuelallan72 commented 4 years ago

Thanks @s0b0lev! Squashed and rebased on master ready for merge. @symbolist did you want to have a final look?

symbolist commented 4 years ago

@swalladge Lets wait until LX-793 is ready as well before merging. Also can you please adds some tests for student_view() & student_view_data() with some complex examples? Pushing fixes will be complicated so better to make sure everything works.

samuelallan72 commented 4 years ago

@symbolist thanks. Do you know if it's possible to do validation on an xblock field when it is set? For example, to prevent any user from setting the wrong type of nested data?

samuelallan72 commented 4 years ago

@symbolist this is ready for final sign off from you. :)

symbolist commented 4 years ago

Remember to squash all commits when merging.