FAL-772 [LX-1827] Ignore missing children in composite blocks

samuelallan72 commented 3 years ago

In the case where a child's xblock data was deleted, we need to gracefully ignore it.

Test instructions:

For each composite xblock (pathway, case study, assignment), delete a child xblock data, and load all the endpoints (including student_view) for the composite xblock.
verify that the deleted children are not displayed, and that no errors are thrown.

Reviewers:

samuelallan72 commented 3 years ago

@symbolist changes done as requested; ready for another review pass. :)

s0b0lev commented 3 years ago

Hey @swalladge, I create a PR https://github.com/open-craft/labxchange-xblocks/pull/17 in the scope of FAL-1496. It solves the same issue. I take your tests from this PR, because they fit new PR quite well :sweat_smile:

samuelallan72 commented 3 years ago

Thanks @s0b0lev , closing as duplicate of #17

Note that #17 covers this use case too, because https://github.com/edx/edx-platform/pull/27068 will coerce all errors to the new xblock parse exception.

labxchange / labxchange-xblocks