labxchange / labxchange-xblocks

XBlocks for LabXchange
Apache License 2.0
2 stars 4 forks source link

Add XBlocks #2

Closed symbolist closed 5 years ago

symbolist commented 5 years ago

Adds the following XBlocks:

bradenmacdonald commented 5 years ago

There are some existing XBlock conventions that I'd like you to use here please:

symbolist commented 5 years ago

@bradenmacdonald I have made the following changes:

  1. Renamed student_view_context() to student_view_data().
  2. Had to keep a separate handler though since the API signature is different.
  3. Moved user state for Assignment out to a separate handler: student_view_user_state().
bradenmacdonald commented 5 years ago

@symbolist Code looks good now, thanks! I will test this together with the other PR and then approve.

Test notes:

bradenmacdonald commented 5 years ago

:+1: for what you have so far.

symbolist commented 5 years ago

@ormsbee I have sent you an invite to a course with these XBlocks setup. Let me know whenever you signup and I can add you as course staff.

ormsbee commented 5 years ago

@symbolist: Did the signup, username dave

symbolist commented 5 years ago

@ormsbee Added to course team.

One note: there is very little styling included. Adding it via the LX frontend to avoid need to bump up this package version whenever we tweak anything.

symbolist commented 5 years ago

Hmm. Looks like the import did not work correctly.

symbolist commented 5 years ago

@ormsbee Okay, so I was in the middle of a rebase when I exported and so the archive was missing the olx. I have created another course with the content and invited you as course staff.

Sorry for the inconvenience!

symbolist commented 5 years ago

@ormsbee Let me know whenever you have completed your testing and I can merge this.

ormsbee commented 5 years ago

@symbolist: Simulation box size seems a bit small, but that's out of the scope of my concerns. LGTM in terms of merging. Thank you.

symbolist commented 5 years ago

@ormsbee Yes, simulations do not fit in the courseware width. We show them in a large modal in the LX interface.