When rendering public_view of composite xblocks call public_view of child xblocks

labxchange / labxchange-xblocks

XBlocks for LabXchange

Apache License 2.0

2 stars 4 forks source link

When rendering public_view of composite xblocks call public_view of child xblocks #9

Closed symbolist closed 4 years ago

symbolist commented 4 years ago

Testing Instructions

Pull this branch. The repo is in devstack/src/.
Do make lms-restart.
As a logged in user, view all the xblocks types from the LX frontend and check that they render correctly.
As a logged out user, view all the xblocks types from the LX frontend and check that they render correctly.

samuelallan72 commented 4 years ago

@symbolist Is there context to why this change was needed?

symbolist commented 4 years ago

@swalladge Oh yes, forgot to mention. Anonymous users can only load the public_view and not student_view (this is enforced in the LMS). Currently, when trying to view a case study or assignment, because the parent XBlock tries to load the student_view of the child XBlocks, a permissions error is returns by LMS. So these two XBlocks currently required the user to be signed in to view them. E.g. https://www.labxchange.org/library/items/lb:LabXchange:68fa1e33:lx_case_study:1