search

labzero / bootleg_phoenix

Provides Phoenix-specific Bootleg tasks.
MIT License
23 stars 7 forks source link

Set MIX_ENV during Phoenix digest #3

Closed rjanja closed 6 years ago

rjanja commented 6 years ago

Corrects the current behavior of digest task not succeeding due to an assumed dev environment.

holetse commented 6 years ago

This PR needs a test associated with the changes.

rjanja commented 6 years ago

As it stands, this package doesn't work for a vanilla Phoenix 1.2 project. The test you are suggesting already exists, it's just not actually throwing an error and failing for reasons I've pointed out in #2 and again in #5. That fix has been separated into another PR at your request. At this point I'm feeling a little discouraged about my contributions back to the project, so maybe it'd be best for me to maintain a fork that works for my purposes and file upstream issues as I encounter them.