search

lacasanova / shortcutrecorder

Automatically exported from code.google.com/p/shortcutrecorder
0 stars 0 forks source link

Code Review - Patch to enable Text Input Sources on Leopard #31

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Purpose of code changes on this branch:

The KL* functions called in SRCommon.m and SRKeyCodeTransformer.m are 
deprecated on Leopard 
and may be removed in 10.6. I've modified the methods so that they use the TIS 
api that is new in 
Leopard. 

After the review, I'd like to add this code into the Leopard branch for 
eventual inclusion in the 
trunk. Note that some kind of preprocessor conditional should be used to keep 
the legacy method 
in place for 10.4 and below.

Cheers,
Michael G

Original issue reported on code.google.com by mgo...@gmail.com on 13 Feb 2009 at 7:51

Attachments:

GoogleCodeExporter commented 8 years ago 
looks to be the exact same code changes that i had made locally.  I will commit 
my 
changes which use the current legacy code for non-64-bit architectures and use 
the TIS 
apis for __LP64__.

Original comment by rarich...@gmail.com on 30 Jun 2009 at 3:12

GoogleCodeExporter commented 8 years ago 
Thanks!
Glad to know this is making it in.

Cheers,
Michael Gozzo

Original comment by mgo...@gmail.com on 30 Jun 2009 at 3:31

GoogleCodeExporter commented 8 years ago 
ultimately it will end up using the TIS code for all architectures, but there 
haven't been 
any discussions yet about dropping support for 10.4.

Original comment by rarich...@gmail.com on 30 Jun 2009 at 4:02

GoogleCodeExporter commented 8 years ago

Original comment by rarich...@gmail.com on 30 Jun 2009 at 6:21