Crash when changing the system appearance color after SRRecorderCell has been deallocated.

What steps will reproduce the problem?
1. Launch Adium (or any app containing shortcutrecorder)
2. Open the preferences window (so a SRRecorderCell is created)
3. Close the preferences window (so this SRRecorderCell is deallocated)
4. Change the "Appearance" color in System Preferences → General (so either 
Aqua or Graphite)

What is the expected output? What do you see instead?
Stuff that needs a different color redraws.

What actually happens: Adium crashes. A crashlog of this can be found here: 
http://trac.adium.im/attachment/ticket/15736/Adium_2011-12-24-230011_Allans-MacB
ook-Pro.crash

What version of the product are you using? On what operating system?
Lion.

Please provide any additional information below.

The SRRecoderCell registers itself with [NSNotificationCenter defaultCenter], 
but it never unregisters itself, causing a crash when the 
NSSystemColorsDidChangeNotification fires but the SRRecorderCell no longer 
exists. I'm attaching a patch that fixes this.

Original issue reported on code.google.com by thijsalk...@gmail.com on 19 Jan 2012 at 12:03

Attachments:

colorchangecrash.diff

lacasanova / shortcutrecorder

Crash when changing the system appearance color after SRRecorderCell has been deallocated. #55