search

lacework / lw-scanner-action

Github Action for running the Lacework Inline Scanner as part of actions workflows
Apache License 2.0
17 stars 13 forks source link

feat: add github summary integration #52

Closed jycamier closed 1 year ago

jycamier commented 1 year ago

Close https://github.com/lacework/lw-scanner-action/issues/51

Summary

Github Summary is a simple way to expose the results of your pipeline to developers in a pull request context.

How did you test this change?

I've added a new pipeline which test it. https://github.com/jycamier/lw-scanner-action/actions/runs/5392578473

image

Issue

https://github.com/lacework/lw-scanner-action/issues/51

timarenz commented 1 year ago

hey, thank you so much for your contribution. can you please make sure you sign your commits as per our guidelines? much appreciated.

jycamier commented 1 year ago

Hi @timarenz Sorry. I thought they were signed. It's fixed.

zachfeld commented 1 year ago

Is there anything blocking this from being merged?

timarenz commented 1 year ago

Just merged and will release. Thank for the contribution.

timarenz commented 1 year ago

Okay, so we need to revert this change as we can not parse the exit code of the lw-scanner command anymore. Exit code is overwritten by the pipe to tee.

jycamier commented 1 year ago

Indeed. Sorry. I'll fix it in a few hours.