lacework / terraform-aws-cloudtrail

Terraform module for configuring an integration with Lacework and AWS for CloudTrail analysis
6 stars 21 forks source link

chore: enable bucket_force_destroy by default #133

Closed afiune closed 1 year ago

afiune commented 1 year ago

Summary

When we use this module to automatically deploy and rollback changes. Users are having constant issues trying to destroy the S3 bucket if it is not empty. To unblock this problem, users need to turn on the bucket_force_destroy flag, and then do any modification that requires a "destroy" operation.

By default, we should allow users to do these operations without the need to know about this flag, if users does not wish to allow these buckets to be destroyed when they are not empty, users should switch off the flag with bucket_force_destroy = false.

How did you test this change?

After merge, we will run our internal pipeline https://github.com/lacework/terraform-customerdemo/pull/70

Issue

https://lacework.atlassian.net/browse/GROW-1336