Error Handling is Unclear on the Frontend

lachlan2k / phatcrack

Modern web-based distributed hashcracking solution, built on hashcat

MIT License

109 stars 8 forks source link

Error Handling is Unclear on the Frontend #22

Open JSmith-Aura opened 11 months ago

JSmith-Aura commented 11 months ago

Howdy,

When entering in a hashlist with a name that is 4 characters or below, e.g "flop" an error is generated:

{
    "message": "Key: 'HashlistCreateRequestDTO.Name' Error:Field validation for 'Name' failed on the 'min' tag"
}

This is fine, however it isnt clearly communicated to the front end:

Which makes it a little hard to diagnose whats wrong.

Version: v0.1.0

Thanks!

lachlan2k commented 9 months ago

Error handling for the Wizard steps has been moved to the new toast error handlers now in commit 10866334d6725f21bec78141474bc952be50d999, which will show the message returns by the API in the toast.

However I will leave this issue open with the following TODOs before we can finally close it:

[x] Ensure the new toast error handling is used for all API requests, so errors are more obvious
[ ] Ensure the UI enforces all the same constraints as the backend, so these errors don't happen in the first place.
[ ] Write a custom error message format that is more friendly than what go-playground/validator gives us. For example, something like "'Name' needs to be a minimum of 4 characters" would be far better.