search

lachlanA / eagle-to-kicad

Eagle SCH/LIB to KiCad SCH/LIB ULP conversion script
GNU General Public License v2.0
424 stars 58 forks source link

eagle6xx-sch-to-kicad-sch.ulp asks wether to apply net list label fix, but ignores choice #9

Closed pgroe closed 8 years ago

pgroe commented 8 years ago

Line 3228: dlgCheckBox("", enableNetListLableFix ); dlgLabel("<nobr><b>Enable Netlist Label Fix</b></nobr>"); dlgSpacing(20); dlgStretch(0);

is the only real occurance of the variable enableNetListLableFix.

It is declared in Line 377: int enableNetListLableFix = 1; but that's all.

No evaluation of its value. Just mentioning.

I stumbled across this, as I like to fix the labes by myself.

@lachlanA : Also mentioning that I really enjoy using the scripts. Great collection - works just fine (with the mentioned downsides of asthetic resulting of this hacks).
pgroe commented 8 years ago

Suggesting patch:

eagle6xx-sch-to-kicad-sch.txt

lachlanA commented 8 years ago

Thanks pgroe, sorry for the slow replie, I have been flying from Europe to Australia for last day or so, so I'm a bit whacked. Will look at your input tomorrow.. when my brain works out what's up and down, and which day it is.. ! Thanks again..

Lachlan

lachlanA commented 8 years ago

Thanks pgroe, sorry for the slow replie, I have been flying from Europe to Australia for last day or so, so I'm a bit whacked. Will look at your input tomorrow.. when my brain works out what's up and down, and which day it is.. ! Thanks again..

Lachlan

lachlanA commented 8 years ago

I have committed you patch and updated the version and build date to reflect your fix. thanks for the help, is nice to have feedback and fix's ! The script's are a really nasty hack, Nothing I'm proud of, as you can see by the mess of code. but Given the limits' of Eagle to KiCad it works most of the time. Thanks again. Lachlan

pgroe commented 8 years ago

No problem ;) Didn't want to hustle you. I'm happy I could contribute, but it's only very simple 2 lines of code, whereas you contributes thousands of lines. So thanks to you!

lachlanA commented 8 years ago

Any bug fix is good ! No matter how small, the coded is such a mess, and I don't get any feed back, just stared, which is nice but having a email saying where the problems are.. and works.. is a 1000% better ! Thanks again for the help.

Lachlan.

On Mon, Jun 13, 2016 at 1:32 PM, pgroe notifications@github.com wrote:

No problem ;) Didn't want to hustle you. I'm happy I could contribute, but it's only very simple 2 lines of code, whereas you contributes thousands of lines. So thanks to you!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/lachlanA/eagle-to-kicad/issues/9#issuecomment-225699382, or mute the thread https://github.com/notifications/unsubscribe/AHdMe6AjHb1QB8HgQYFFWs3WRPKBAZRcks5qLb5hgaJpZM4IyM7m .