search

lachlanmcdonald / magicavoxel-shaders

A collection of shaders for MagicaVoxel to generate geometry, noise, patterns, and simplify common and repetitive tasks.
Other
626 stars 50 forks source link

Cover Shader. How it works? #27

Closed p1b1 closed 3 years ago

p1b1 commented 3 years ago

Hello. I'll start by saying that contacting you is the last option left for me. I can not cope with the shader from your package, namely 'cover'. I have no idea how to use it to work as you show in the examples on the wiki. Can you explain to me how it works? I'm probably too stupid to use it and am doing something wrong, but I can't find anywhere an example of how others work with this shader. Bez tytułu

p1b1 commented 3 years ago

It could be that this shader is not working. I contacted other MagicVoxel users about this and the latest version does not work for them either.

ericschn commented 3 years ago

Removing usage of the clamp function allows it to work on nVidia hardware for me.

p1b1 commented 3 years ago

That's right. Now it works without any problem :)

Just swap: float headroom = clamp(1.0, 255.0, m_headroom); float noise = clamp(0.0, 1.0, m_noise);

To: float headroom = m_headroom; float noise = m_noise;

Thank you for your help :)

lachlanmcdonald commented 3 years ago

Thanks for the heads up @ericschn, clamp seems to be causing lots of trouble. I think I'll need to do some tests to work out the edge-cases.

lachlanmcdonald commented 3 years ago

Removed clamp from the shaders to avoid issues until I can investigate why. Will be part of 0.12.0 release.