Update Dockerfile to correct build issues

lacion / cookiecutter-golang

A Go project template

MIT License

687 stars 177 forks source link

Update Dockerfile to correct build issues #15

Closed jrnt30 closed 6 years ago

jrnt30 commented 6 years ago

Running make package I ran into an error:

GOPATH=/gopath
go build -ldflags '-w -linkmode external -extldflags "-static" -X main.GitCommit=844219fde13bf43b1d592498393589445618b232 -X main.VersionPrerelease=VersionPrerelease=RC' -o bin/ark-watchman
go: cannot find GOROOT directory: /usr/lib/go
make: *** [Makefile:37: build-alpine] Error 2

Running go env in the container I found GOROOT to be /usr/local/go not /usr/lib/go.

lacion commented 6 years ago

I going to go ahead and close this because I already had a fix pending to be pushed, but I went ahead and added you to contributors for creating the PR. most of the envs in the docker file are no longer needed, so I did an extra cleanup.

jrnt30 commented 6 years ago

Understood. Thanks for the helpful work.