lacuna-tech / mds-core

Repo for LADOT MDS implementation for contribution to the Open Mobility Foundation
Apache License 2.0
13 stars 9 forks source link

PLAT-382 - convert mds-compliance-engine to Jest #949

Closed nessur closed 2 years ago

nessur commented 2 years ago

📚 Purpose

[Convert all tests in mds-compliance-engine from mocha to jest]

👌 Resolves:

📦 Impacts:

[mds-compliance-engine]

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 51fe6104a0fd6dffb2cd543700820c3f9ad9959f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ---------------------------------------- | ----- | | @mds-core/mds-compliance-engine | Patch | | @mds-core/mds-compliance-batch-processor | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

nessur commented 2 years ago

Any chance to convert done => {...; done() } to async () => { ...; } in these test suites? Also, looks like a before was missed.

Screen Shot 2022-03-21 at 5 02 34 PM

All cleaned up! done() are gone.