lacuna-tech / mds-core

Repo for LADOT MDS implementation for contribution to the Open Mobility Foundation
Apache License 2.0
13 stars 9 forks source link

[PLAT-511] Tune isInStatesOrEvents checks #988

Closed avatarneil closed 2 years ago

avatarneil commented 2 years ago

📚 Purpose

This PR makes a couple changes:

  1. Fixes a regression which was introduced during a major refactor like 8 months ago, where we didn't respect a device's mode when checking it against policies
  2. Updates handling of an empty states object (like states: {}) on rules by returning true versus false

👌 Resolves:

PLAT-511

📦 Impacts:

See changesets

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 76b859045ccb5c7ffbf89ad774ad47b8dc9cc242

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ---------------------------------------- | ----- | | @mds-core/mds-compliance-engine | Patch | | @mds-core/mds-compliance-batch-processor | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR