lacymorrow / casper

Casper 👻 theme for Wordpress
http://lacymorrow.com/casper
GNU General Public License v2.0
557 stars 93 forks source link

add theme support for the title tag #103

Closed maavuz closed 7 years ago

maavuz commented 8 years ago

i noticed this when i was looking into header.php file there is tag i don't think it is a good idea to use <title>. Since Version 4.1, themes should use add_theme_support() in the functions.php file in order to support title tag</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/lacymorrow"><img src="https://avatars.githubusercontent.com/u/1311301?v=4" />lacymorrow</a> commented <strong> 8 years ago</strong> </div> <div class="markdown-body"> <p>Hi @maavuz, thanks for the contribution!</p> <p>I agree with the change, but don't have time to test. It looks good from here, have you tested and verified it working? If so, I'll go ahead and merge.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/maavuz"><img src="https://avatars.githubusercontent.com/u/1773992?v=4" />maavuz</a> commented <strong> 8 years ago</strong> </div> <div class="markdown-body"> <p>Hi @lacymorrow yes i have tested it and its perfect. :)</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>