lacymorrow / crossover

🎯 A Crosshair Overlay for any screen.
https://lacymorrow.github.io/crossover
Other
887 stars 96 forks source link

CrossOver doesn't work in Fullscreen mode #64

Open alecs91 opened 3 years ago

alecs91 commented 3 years ago

It seems that CrossOver doesn't work on EFT: As soon as i set up the crosshair and then alt-tab in the EFT screen the crosshair disappears. If i press any keyboard shortcut like alt+ctrl+maiusc+x (or 'h', or whatever) the game screen minimize and it brings me back to the desktop. Suggestions? Edit: It works with "screen mode borderless". It doesn't work with "screen mode fullscreen"

lacymorrow commented 3 years ago

@alecs91 Unfortunately fullscreen mode doesn't work in most games, however there is a workaround using AutoHotKey https://github.com/lacymorrow/crossover#workaround

kyle-go commented 2 years ago

@lacymorrow I found a way to work in fullscreen mode. You can find the code in the link blow.

https://github.com/electron/electron/issues/26350#issuecomment-1128813997

lacymorrow commented 2 years ago

@kyle-go What OS and Electron version are you using?

Your example code is almost identical to what I use with crossover already, unfortunately.

I would LOVE to find a workaround to this issue though.

AndrazPustotnik commented 2 years ago

Any news here yet? :/

lacymorrow commented 2 years ago

This is the issue blocking things: https://github.com/electron/electron/issues/26350#issuecomment-1128813997

AndrazPustotnik commented 2 years ago

I digged into it a little bit. And since fullscreen mode gives app the ability to use the graphic card in fully it means that in order to do overlay on top of that, some kind of gpu library would need to be used like DirectX or OpenGL. It makes whole problem a lot more complicated and if we would be using it on top of video game we may have problems with anti cheat stuff... :/
Ask Discord how they did it :P

lacymorrow commented 2 years ago

Most likely a proprietary native extension, which would be hard for me to support as the sole dev on the project.

GreenMan36 commented 1 year ago

I noticed my Steam popped up with a friend launching Crosshair X and I went to check it out and tell him CrossOver is free. But then I noticed this update post which says they have Exclusive Fullscreen support thanks to the Xbox Game Bar Extension support on Windows 10 and 11.

Maybe this can be looked into? They still have it in Beta but clearly this is an option. It may require significant work but I think its worth researching, maybe even making an issue or project board for it?

lacymorrow commented 1 year ago

Definitely worth researching! Thanks for flagging!

k9dog-gmail commented 1 year ago

Found a workaround X (at least xfce4) windows have an option to go full screen .. now you can alt-tab to browser etc Collect that with games that only go fullscreen where you can run in vitual desktop and you can actually use it.

websharik commented 1 year ago

FPS Monitor can working with most fullscreen apps. How ?

I was try draw just red dot use more langs/libs and too cant do it on fullscreen app(

lacymorrow commented 1 year ago

@websharik It's written in another language and is injecting itself directly into Vulkan/DirectX.

It's possible (discord does it), but very difficult for one person to maintain in their free time.

lacymorrow commented 1 year ago

@GreenMan36 Can I ask what your friend likes about Crosshair X? I'd love to catch up to the competition... for free

GreenMan36 commented 9 months ago

@GreenMan36 Can I ask what your friend likes about Crosshair X? I'd love to catch up to the competition... for free

I have no clue, I can't remember which friend was using it. A simple plus is that it's available on Steam, with auto updates. Community workshop. The UI looks decent and you can share your configs. It seems to have great crosshair creator. Lots of settings.

One thing I'm not seeing is game-specific crosshair settings. That would be great to have. Auto-hiding and changing the crosshair based on what program is focussed could be super-b.

repo-ranger[bot] commented 6 months ago

⚠️ This has been marked to be closed in 7 days.

Pen9G commented 4 months ago

Hello, i think Xbox Game Bar Widget is a good solution for Fullscreen game crosshair overlay. I have used some crosshair widgets on Xbox Game Bar myself, and i tried develop a Xbox Game Bar Crosshair Overlay Widget myself last week, its quite simple because Xbox Game Bar Widget is a common UWP application.

The only problem may be that Xbox Game Bar Widget cannot listen to background mouse events, so "Hide on ADS" needs an extra desktop app to communicate with the Xbox Game Bar Widget. As i know the Xbox Game Bar Version of Crosshair X need the desktop app to run at same time too.

Danalytics-dan commented 2 months ago

Hello, i think Xbox Game Bar Widget is a good solution for Fullscreen game crosshair overlay. I have used some crosshair widgets on Xbox Game Bar myself, and i tried develop a Xbox Game Bar Crosshair Overlay Widget myself last week, its quite simple because Xbox Game Bar Widget is a common UWP application.

The only problem may be that Xbox Game Bar Widget cannot listen to background mouse events, so "Hide on ADS" needs an extra desktop app to communicate with the Xbox Game Bar Widget. As i know the Xbox Game Bar Version of Crosshair X need the desktop app to run at same time too."

It would be a good solution, however there is no target audience while using it. Xbox game bar uses performance since it has to run while the game is running and so anyone trying to squeeze all performance out of their system will disable it, myself included.

If you don't care about performance and have game bar enabled then the pre-existing electron method is just as good, since you only have to go to bordered fullscreen (which reduces performance, about as much as game bar)

tldr: -Isn't good for those who want maximum performance -Is equally good as the existing technique for everyone else So no-one benefits.

The proper fix to this issue would be to hook into the actual vulkan/directx process (with a more mid level language so that you have higher control over memory etc such as C++), in order to get Best performance and functionality. Doing this would require a lot of work though which is why only paid products such as Hudsight support it, so that the devs can spend more time developing it.

Pen9G commented 2 months ago

tldr: -Isn't good for those who want maximum performance -Is equally good as the existing technique for everyone else So no-one benefits.

I actually don't think Xbox Game Bar will cause any obvious game performance reduce, at least compared to toggling Exclusive Fullscreen to Fullscreen. I've been using Xbox Game Bar in games like Hunt: Showdown, and I never notice any FPS drop after activating Xbox Game Bar(I make sure no Game Bar process was running).

Besides, the fact that some Crosshair overlay app such as CrosshairX have their own Game Bar edition indicates the advantages of Xbox Game Bar over solutions just not using Exclusive Fullscreen, right?

Danalytics-dan commented 2 months ago

I actually don't think Xbox Game Bar will cause any obvious game performance reduce, at least compared to toggling Exclusive Fullscreen to Fullscreen. I've been using Xbox Game Bar in games like Hunt: Showdown, and I never notice any FPS drop after activating Xbox Game Bar(I make sure no Game Bar process was running).

Besides, the fact that some Crosshair overlay app such as CrosshairX have their own Game Bar edition indicates the advantages of Xbox Game Bar over solutions just not using Exclusive Fullscreen, right?

Xbox game bar cannot be disabled apart from with special tools, such as Atlas OS or with tweaking software - or removing permissions from running in the background. People trying to squeeze every % of performance out of their pc will try to reduce as many windows background processes as possible including game bar.

While game bar might not lose quite as much fps as Exclusive Fullscreen it still will do and so for those trying to get as much performance it isn't viable.

tldr: -slightly better for those who don't care about performance -people who care seriously about performance still won't use it -takes effort to implement

Having said that, a toggle-able option would be better than nothing of course for the niche people it would benefit.