search

lad1337 / Sick-Beard

PVR & episode guide that downloads and manages all your TV shows
http://code.google.com/p/sickbeard/
GNU General Public License v3.0
70 stars 26 forks source link

extended fix for post processing 1080p files to also include 720p files #23

Open orangepeelbeef opened 10 years ago

orangepeelbeef commented 10 years ago

updated anime_bare regex to also not capture 720p files

tested captures against Strike.Back.S02E09.Mini.720p.HDTV.x264-ITSat.mkv Strike.Back.S02E09.Mini.1080p.HDTV.x264-ITSat.mkv [ACX]_Wolf's_Spirit_001.mkv One Piece - 102

Anthirian commented 10 years ago

I also noticed some issues with 720p and was in the process of developing a fix. I will try yours when I am again near a computer to do some more tests.

Anthirian commented 10 years ago

I tested your code and it seems to be working properly (i.e. only match the anime) for the following filenames.

"Homeland.S03E04.Game.On.1080p.WEB-DL.DD5.1.H.264-BS"
"the.graham.norton.show.s14e01.720p.hdtv.x264-ftp.mkv"
"That '70s Show S07E03 (I Can't Get No) Satisfaction 720p HDTV DD5.1 MPEG2-TrollHD"
"One Piece - 102"
"[ACX]_Wolf's_Spirit_001.mkv"
"Person.Of.Interest.S03E06.Mors.Praematura.720p.WEB-DL.H.264.DD5.1-BTN.mkv"

The only issue I noticed is that absolute numbering for anime can also have two digits instead of 3, which is mandatory for this regex. See the example below.

"[Kaitou] Strike the Blood - 04 [720p][8DAC92B2]"

I am assuming the other regexes will pick up files named like this, because they all assume 1 to 3 digits for the absolute number. This means that extreme cases like "One Piece - 39" may not get picked up correctly though.

orangepeelbeef commented 10 years ago

Well prior to my change that was still the case. I only added the bit for 720p, the \d{3} bit was already there

On Sat, Nov 9, 2013 at 9:11 AM, Geert notifications@github.com wrote:

I tested your code and it seems to be working properly (i.e. only match the anime) for the following filenames.

"Homeland.S03E04.Game.On.1080p.WEB-DL.DD5.1.H.264-BS" "the.graham.norton.show.s14e01.720p.hdtv.x264-ftp.mkv" "That '70s Show S07E03 (I Can't Get No) Satisfaction 720p HDTV DD5.1 MPEG2-TrollHD" "One Piece - 102" "[ACX]_Wolf's_Spirit_001.mkv" "Person.Of.Interest.S03E06.Mors.Praematura.720p.WEB-DL.H.264.DD5.1-BTN.mkv" "Bleach.s16e03-04.313-314"

The only issue I noticed is that absolute numbering for anime can also have two digits instead of 3, which is mandatory for this regex. See the example below.

"[Kaitou] Strike the Blood - 04 [720p][8DAC92B2]"

I am assuming the other regexes will pick up files named like this, because they all assume 1 to 3 digits for the absolute number. This means that extreme cases like "One Piece - 39" may not get picked up correctly though.

— Reply to this email directly or view it on GitHubhttps://github.com/lad1337/Sick-Beard/pull/23#issuecomment-28131732 .

Anthirian commented 10 years ago

Yeah I know, I made that a while back. I was just thinking out loud: the anime_bare regex is not ideal but it will serve as a workaround.