Error with Blackhole downloader

jmichiel commented 10 years ago

I wrote a torrent Indexer plugin for PublicHD, but when I try to use it with BlackHole Downloader, I get the following error in the log:

Error during addDownload of Blackhole (Default) 
Error: 'Download' object has no attribute 'extra_data'

Traceback (most recent call last):
  File "/volume1/@appstore/xdm/xdm/plugins/meta.py", line 159, in outer
    return run(*args, **kwargs)
  File "/usr/local/xdm/plugins/Downloader/Blackhole-de_lad1337_blackhole-0_5/Blackhole.py", line 46, in addDownload
    headers = download.extra_data['headers'] if 'headers' in download.extra_data else { }
AttributeError: 'Download' object has no attribute 'extra_data'

New value:False
Traceback:
Traceback (most recent call last):
  File "/volume1/@appstore/xdm/xdm/plugins/meta.py", line 159, in outer
    return run(*args, **kwargs)
  File "/usr/local/xdm/plugins/Downloader/Blackhole-de_lad1337_blackhole-0_5/Blackhole.py", line 46, in addDownload
    headers = download.extra_data['headers'] if 'headers' in download.extra_data else { }
AttributeError: 'Download' object has no attribute 'extra_data'

Have I forgotten something? I copy-pasted some code from the Newznab Indexer, but there's nothing about extra_data there...

lad1337 commented 10 years ago

which version of XDM are you running ? every Download object should have a .extra_data attribute :/ https://github.com/lad1337/XDM/blob/master/xdm/classes.py#L887

/status should give you the version number and some more info you could also have used the log page to post this issue and it would add system information from your traceback i assume its a synology

Torf commented 10 years ago

Ive got same issues from users of my plugins... It seems that master branch isnt up to date and doesn't have the extradata property. It may be Nice to update It ? Le 20 nov. 2013 21:32, "lad1337" notifications@github.com a écrit :

which version of XDM are you running ? every Download object should have a .extra_data attribute :/ https://github.com/lad1337/XDM/blob/master/xdm/classes.py#L887

/status should give you the version number and some more info

you could also have used the log page to post this issue and it would add system information from your traceback i assume its a synology

— Reply to this email directly or view it on GitHubhttps://github.com/lad1337/XDM-main-plugin-repo/issues/6#issuecomment-28928132 .

lad1337 commented 10 years ago

i just did a complete install with a git clone (default is master) and the blackhole plugin worked fine ...

what version of XDM are you using ? fyi i do not control the synology package

jmichiel commented 10 years ago

the version used in the synology package is: Version: Zim 0.5.9 And indeed, during development, I didn't have any issue either while using the latest master... I'll kindly ask the package maintainer to update to the latest master ;-)

jmichiel commented 10 years ago

Manually updating the source solved it!

lad1337 / XDM-main-plugin-repo

Error with Blackhole downloader #6