search

lad1337 / XDM

XDM: eXtendable Download Manager. Plugin based media collection manager.
xdm.lad1337.de
Other
203 stars 46 forks source link

removing 'comment_on_download' don't remove the settings in plugin page #123

Closed Nonobis closed 6 years ago

Nonobis commented 10 years ago

hi,

all is in the title :)

with a config like this, i have always 'comment on download' on the plugin settings page.

_config = {'enabled': True}

Could you make it optional ?

image

Torf commented 10 years ago

Protip: it is useless to set the 'enabled' option, prefere to let XDM set it.

It would be great to have a bool to set in order to activate the comment on a indexer. "_hasComment = True" (disabled by default).

schumi2004 commented 10 years ago

What does Comment on Download do anyway? Seen it multiple times now.

lad1337 commented 10 years ago

It was an idea I had at the beginning: If the download succeeds or fails it would create a comment on the newznab indexer something like:

"Automatic XDM: completed without an issue" Or "Automatic XDM: failed, missing blocks"

But I never found a newznab indexer where this api call worked

schumi2004 commented 10 years ago

Thanks for explaining. Sounds cool though but could get people banned for spamming threads (if provider doesn't like it)

lad1337 commented 10 years ago

Yeah I am asking some indexers if they would mind anything like that so far no one would but then again I haven't found the right way to call the api ...