search

lad1337 / XDM

XDM: eXtendable Download Manager. Plugin based media collection manager.
xdm.lad1337.de
Other
203 stars 46 forks source link

Cache image file path too long #124

Closed Ceveos closed 9 years ago

Ceveos commented 10 years ago

So when adding an anime, it caches the image to 'D:\XDM\images\de.uranime.anime'

Anyway, there's a couple of images where the file path is simply too long, like, one picture is named: Ore no Nounai Sentakushi ga Gakuen Lovecome o Zenryoku de Jama Shiteiru e08 My Freeloader Cant Be This Smart My Thing Cant Be This Amazing! (153) screencap_image-uranime - Copy.jpeg

and that's not short by any means. Can we have a splitter that'll split the path to the appropriate size? It's erroring out because it can't find an image because it could never save it in the first place.

lad1337 commented 10 years ago

This is windows, isn't it? But the issue is acknowledge ... What do you mean by splitter ? I would have simply removed the element name

Torf commented 10 years ago

It would be better to use the uranime Id or an incremented id instead of the name. But the issue is on the wrong github project.

lad1337 commented 10 years ago

@Torf
No it's okay here since XDM decides what it names the images ... And there is already an id in there so it's unique even without the name. I just added it in the first place to have more human friendly names

Torf commented 10 years ago

my mistake, sorry.

Ceveos commented 10 years ago

Oh, my mistake. I guess a better way to describe it is substring. If the length of the path is greater than 256 characters, then only read the first 251 characters of the path since 5 characters are used for the extension. However, you mentioned that you'd be simply changing the naming scheme which would work as well.

Also, yes, I'm on Windows.