Closed an0Nym0us63 closed 11 years ago
is this happening with every game ? only games? do you use the sab downloder or the blackhole(i guess not) ? ... i never saw this happening ... what do the events for that game say? do they mention two snatches ?
i only tested for games as i use my own sickeard, headphones, and cps forks. But i hope one day only have one app like yours ;) but for now as i'm used with theothers and i adapted them for my use i only use XDM for games (as the development for gamez stopped)
i don't use blackhole i send them directly to sab
here is an event for one game for example
today : 5:37pm update new status Downloading
today : 5:30pm update Resantched: Game(de.lad1337.games) Max Payne 3
today : 5:30pm snatchTry Trying to snatch Max.Payne.3-RELOADED with Sabnzbd (Default)
today : 5:30pm result Newznab (Default) found 10 results
today : 5:30pm search Searching Game(de.lad1337.games) Max Payne 3 on Newznab (Default)
today : 5:30pm update new status Snatched
today : 5:30pm snatchTry Trying to snatch Max.Payne.3-RELOADED with Sabnzbd (Default)
today : 5:30pm result Newznab (Default) found 10 results
today : 5:30pm search Searching Game(de.lad1337.games) Max Payne 3 on Newznab (Default)
today : 5:29pm update Save without a data change.
today : 5:29pm update new status Wanted
you can see that at the moment it is added it searches and snatches twice
For now as i noticed it does that for every game.
I have another question (i made lots of providers for sick, CPS and headphones, and i was wondering if it could be easy to add some in XDM ? (did'nt look at the code yet) but i found strange to see a torrent section in the app but no providers for them are they hidden ? (for now i never saw a snatch from a torrent.
as i said i'm a home coder and did lots of work on my forks of sick, cps and headphones. But i'm new to xdm and i find the concept great but some options seems strange for now.
As is saw and tell me if i'm wrong : there a no torrent providers ? and the only nzb provider are newznab based ?
thanks for all
about indexer (indexer give downloader and providers give meta information): well yeah its quite easy too add one / many as plugins first and only one so far is the genric newznab https://github.com/lad1337/XDM/blob/master/plugins/indexer/Newznab.py
the documentation for indexers is wrong and lacking behind ! but for the basic structure and idea of plugins https://xdm.readthedocs.org/en/latest/plugin/index.html#getting-started this might help.
basic idea is that indexer return a list of Download(https://github.com/lad1337/XDM/blob/master/xdm/classes.py#L706) object i will try to write more documentation in the near future
ok thanks i will look at that.
So we are ok to say that there are no torrents for now and only newznab.
One question i have two newznab instances, does it search the second one only if it didn't find something on the first one ? it seems like that i think
As if i activate both of them i only see lonks of the first one. But if i activate only the second one and i do a research i see links of the second one appear in download links ?
did you have any clue for the games being snatched twice
One question i have two newznab instances, does it search the second one only if it didn't find something on the first one ? it seems like that i think
yes: https://github.com/lad1337/XDM/blob/master/xdm/tasks.py#L129 it leaves the provider loop when a snatch was successful
actually there is a bug/error ... it does not check weather the snatch was successful it just exits the loop when we tried to snatch something from one provider.
apparently your sab does not report back correctly / or i dont handle all available answers since there is no event that corresponds to https://github.com/lad1337/XDM/blob/master/xdm/tasks.py#L152 only the "trying to snatch" line
BUT looking at sab plugin https://github.com/lad1337/XDM/blob/master/plugins/downloader/Sabnzbd.py#L61 the only reason it would report back a failure is a timeout since other stuff is not taken into account (uups) have a look at the look file while you search for an element and look if there is something like
"Unable to connect to Sanzbd. Most likely a timout. is Sab running"
BUT since you have the stuff in sab, it is not quick enough to report back ... that might be that the downloading of the nzb takes longer then 10 sec ... so i should probably just increase that time to 30sec to something
Ok ill check all that.
I think it would be better to search all instances like that the downloaded links page will have all links available
De: lad1337 Envoyé: lun., 24/06/2013 14:42 A: lad1337/XDM XDM@noreply.github.com CC: sarakha63 sarakha_ludovic@yahoo.fr Objet: Re: [XDM] game snatched twice (#8)
One question i have two newznab instances, does it search the second one only if it didn't find something on the first one ? it seems like that i think
yes: https://github.com/lad1337/XDM/blob/master/xdm/tasks.py#L129 it leaves the provider loop when a snatch was successful
actually there is a bug/error ... it does not check weather the snatch was successful it just exits the loop when we tried to snatch something from one provider.
about the two snatches
apparently your sab does not report back correctly / or i dont handle all available answers since there is no event that corresponds to https://github.com/lad1337/XDM/blob/master/xdm/tasks.py#L152 only the "trying to snatch" line
BUT looking at sab plugin https://github.com/lad1337/XDM/blob/master/plugins/downloader/Sabnzbd.py#L61 the only reason it would report back a failure is a timeout since other stuff is not taken into account (uups) have a look at the look file while you search for an element and look if there is something like
"Unable to connect to Sanzbd. Most likely a timout. is Sab running"
BUT since you have the stuff in sab, it is not quick enough to report back ... that might be that the downloading of the nzb takes longer then 10 sec ... so i should probably just increase that time to 30sec to something
— Reply to this email directly or view it on GitHub.
I think it would be better to search all instances like that the downloaded links page will have all links available
jap changed that
AND increased the timeout (default value, i guess thats set by urllib), so the double snatch should be fixed (also added a check of the sab response)
So we are ok to say that there are no torrents for now and only newznab. yes
thanks for all i will give a test (the project is a great idea)
thanks :) ... i just noticed the new version crashes on my other machine you might want to hold of ... or it might work ... its something with the new translation system
yes error on translation line 77 system.py
just commented the line to test (language-team doesn't exist)
even with that i can't go to the core menu settings
File "C:\Users\sarak_000\Downloads\XDM-master\rootLibs\jinja2\environment.py", line 894, in render return self.environment.handle_exception(exc_info, True) File "html\templates\settings.html", line 4, in top-level template code {% set active_sub_page = active_subpage|default('settings') -%} File "html\templates\base.html", line 143, in top-level template code {% block content %} File "html\templates\settings.html", line 61, in block "content" {% for k,v in plugin[''+config.name]().items() %} File "C:\Users\sarak_000\Downloads\XDM-master\xdm\plugins\bases.py", line 930, in _release_threshold_select 1: format_timedelta(helper.releaseThresholdDelta[1]), File "C:\Users\sarak_000\Downloads\XDM-master\rootLibs\babel\dates.py", line 649, in format_timedelta plural_form = locale.plural_form(value) AttributeError: 'NoneType' object has no attribute 'plural_form'
something must have gone wrong with the commit
yeah but since i only have that issue on another system (i would not send out anything that does not run on my dev box :P) so i have to compile it everytime i check something ... well thats what i am doing now all translations are missing so it seams ... are you running from source ? because i can see the mo files missing tin the binarys but they should be there on the source version
i'm running directly from the source from master branch
okay ... cloned it about 10 minutes ago and i noticed that the i18n folder was missing ... but its was/is on gihub then i deleted the folder and cloned it again ... now the i18n folder is present and everything is running ... fyi i opened a channel on irc.freenode.net #xdm
i have the i8n folder and i still have the error for language-team and if i comment the log line it starts but ca'nt go to the core pugins settings.
I can't go on irc for now
here is the exact traceback when clicking on core plugins settings
File "html\templates\base.html", line 143, in top-level template code {% block content %} File "html\templates\settings.html", line 61, in block "content" {% for k,v in plugin['_'+config.name]().items() %} File "C:\Users\sarak_000\Downloads\XDM-master(1)\XDM-master\xdm\plugins\bases.py", line 930, in _release_threshold_select 1: format_timedelta(helper.releaseThresholdDelta[1]), File "C:\Users\sarak_000\Downloads\XDM-master(1)\XDM-master\rootLibs\babel\dates.py", line 649, in format_timedelta plural_form = locale.plural_form(value) AttributeError: 'NoneType' object has no attribute 'plural_form'
it is linked with the new date gestion implemented
translation selection should be fixed -> fallback to en_US also please check the double snatch issue
OK for now it starts without problem
But i still can't go in the core and plugins settings page
here is the error
Traceback (most recent call last): File "C:\Users\sarakhal\Downloads\XDM-master\XDM-master\rootLibs\cherrypy_cprequest.py", line 656, in respond response.body = self.handler() File "C:\Users\sarakhal\Downloads\XDM-master\XDM-master\rootLibs\cherrypy\lib\encoding.py", line 188, in call self.body = self.oldhandler(_args, _kwargs) File "C:\Users\sarakhal\Downloads\XDM-master\XDM-master\rootLibs\cherrypy_cpdispatch.py", line 34, in call return self.callable(_self.args, _self.kwargs) File "C:\Users\sarakhal\Downloads\XDM-master\XDM-master\xdm\webinit.py", line 137, in settings return template.render(plugins=common.PM.getAll(True), **self._globals()) File "C:\Users\sarakhal\Downloads\XDM-master\XDM-master\rootLibs\jinja2\environment.py", line 894, in render return self.environment.handle_exception(exc_info, True) File "html\templates\settings.html", line 4, in top-level template code {% set active_sub_page = active_subpage|default('settings') -%} File "html\templates\base.html", line 143, in top-level template code {% block content %} File "html\templates\settings.html", line 61, in block "content" {% for k,v in plugin[''+config.name]().items() %} File "C:\Users\sarakhal\Downloads\XDM-master\XDM-master\xdm\plugins\bases.py", line 930, in _release_threshold_select 1: format_timedelta(helper.releaseThresholdDelta[1]), File "C:\Users\sarakhal\Downloads\XDM-master\XDM-master\rootLibs\babel\dates.py", line 649, in format_timedelta plural_form = locale.plural_form(value) AttributeError: 'NoneType' object has no attribute 'plural_form'
SO i can't configure anything to do my tests ;)
pushed new stuff to the master please give it a try :)
so conclusion
Game is only snatcehd once
And in my downloads i can see all the providers great stuffffffffffffffffff.
I have some other ideas
Clap clap very good job
first of all great project
i noticed a bug while downloading games when adding a game the same file is snatched twice and sent two times to sab