More dedup and a more expressive ChangeObject

ladda-js / ladda

JavaScript data fetching layer with caching

https://petercrona.gitbooks.io/ladda/content/

MIT License

112 stars 16 forks source link

More dedup and a more expressive ChangeObject #26

Closed LFDM closed 7 years ago

LFDM commented 7 years ago

Calls dedup at the beginning and at the end of the plugin chain for a maximum effect
Moves the onChange hook out of the EntityStore, which doesn't have this odd side effect anymore. Operations trigger the notification now, which also allows us to provide more information (e.g. about the function which has triggered the change!)

coveralls commented 7 years ago

Coverage increased (+0.2%) to 99.38% when pulling 87f2c1da9ab8d9eae29f1865814cfeee63789a5d on feat/dedup-and-change-hook into 1f579db4b4abcf826ab5d7b6f994fbc1b5354a32 on master.

coveralls commented 7 years ago

Coverage increased (+0.2%) to 99.38% when pulling e95859c948d1701cb91e7951ac6f89d5ad39372a on feat/dedup-and-change-hook into 1f579db4b4abcf826ab5d7b6f994fbc1b5354a32 on master.

coveralls commented 7 years ago

Coverage increased (+0.2%) to 99.38% when pulling e95859c948d1701cb91e7951ac6f89d5ad39372a on feat/dedup-and-change-hook into 1f579db4b4abcf826ab5d7b6f994fbc1b5354a32 on master.

coveralls commented 7 years ago

Coverage decreased (-0.1%) to 99.08% when pulling 27a2aab86ed8609a4818b99adc083c6c5e40b631 on feat/dedup-and-change-hook into 1f579db4b4abcf826ab5d7b6f994fbc1b5354a32 on master.

coveralls commented 7 years ago

Coverage increased (+0.2%) to 99.387% when pulling bed673d4626fb15d32edc0e14cf80625f3ee9bc9 on feat/dedup-and-change-hook into 1f579db4b4abcf826ab5d7b6f994fbc1b5354a32 on master.

LFDM commented 7 years ago

I am a little confused as to why coveralls thinks that we're not testing all branches in validator. Looks perfectly fine to me :/ Do you have an idea, @petercrona?

coveralls commented 7 years ago

Coverage increased (+0.3%) to 99.54% when pulling aa7d9e36e50b23a5d9eb3b5a0344bd7acc42b955 on feat/dedup-and-change-hook into 1f579db4b4abcf826ab5d7b6f994fbc1b5354a32 on master.

LFDM commented 7 years ago

Ok, the coverage report thinks that we're missing else branches here, which we aren't. Could try to rewrite this code a bit (which could be done nicer anyway), but maybe not know. Badge is rounded up anyway and shows 100% again ;)