search

ladiesofcode / london

A space for the London LOC community, including past presentations
12 stars 7 forks source link

Adds notes for lightning talks (master branch) #17

Closed RabeaGleissner closed 9 years ago

RabeaGleissner commented 9 years ago

Hi @iteles,

Here's the pull request for the master branch. Hope it's fine!

iteles commented 9 years ago

Hi @RabeaGleissner, this is totally fine, thanks for opening it.

However, seeing as your previous PR merged your work into the 2015october branch, you could just PR from there to master? It's a bit more traceable if people are looking back to understand the various commits.

Sorry, this is just my 'teaching' coming out here. It doesn't make a real difference in this case, but I'm a stickler for 'best practice' :wink:

Also, you're an owner on the repo so feel free to make the changes directly without having to fork from now on :blush:

RabeaGleissner commented 9 years ago

@iteles Thank you! To be honest, I have very little experience with pull requests and forking etc. so please keep up the teaching :smile_cat: Will create a pull request from from the branch.