search

ladisk / pyuff

This module defines an UFF class to manipulate with the UFF (Universal File Format) files.
Other
58 stars 40 forks source link

BUG: dataset 2420, read and write keys are not the same #50

Open jasasonc opened 3 years ago

jasasonc commented 3 years ago

The keys in output dictionary when reading dataset 2420 are different from expected keys when writing this set.

https://github.com/ladisk/pyuff/blob/202f0d33977d1f8e0ef3795c2f275b9e40657c54/pyuff/datasets/dataset_2420.py#L31

https://github.com/ladisk/pyuff/blob/202f0d33977d1f8e0ef3795c2f275b9e40657c54/pyuff/datasets/dataset_2420.py#L8

Similar issue is present in dataset 2411. Partially connected to #43

jankoslavic commented 2 years ago

@jasasonc is this still an issue?

jasasonc commented 2 years ago

Yes.
write2420 requires keys: part_UID, part_name, cs_type, cs_color, nodes.

extract2420 creates keys: Part_UID, Part_Name, CS_sys_labels, CS_types, CS_colors, CS_names, CS_matrices

jankoslavic commented 2 years ago

Dear @jasasonc thank you!

I see! The extract2420 follows the datatype specifications available here: https://www.ceas3.uc.edu/sdrluff/view.php We have a partial test here: https://github.com/ladisk/pyuff/blob/master/tests/test_2420.py

We need help in handling this issue and also a real dataset.