search

ladisk / pyuff

This module defines an UFF class to manipulate with the UFF (Universal File Format) files.
Other
58 stars 40 forks source link

Bugfix writing 2414 #70

Closed toonijn closed 1 year ago

toonijn commented 1 year ago

This fixes a bug on writing dataset 2414.

jankoslavic commented 1 year ago

Thank you @toonijn. It looks simple, but I would like to ask @michaelquaglia for a comment as he initially coded this dataset.

jankoslavic commented 1 year ago

We would also need a test for this. @toonijn could you doit?

michaelquaglia commented 1 year ago

@jankoslavic I only used 2414/analysis_type = 5 on my side so I could not test the fix. I would also like to say that I did not initially coded this dataset but expanded it for 1 and 2D input data :). Previously it was only working for 3D data. Thanks a lot @toonijn

jankoslavic commented 1 year ago

Thank you @michaelquaglia . Anyway, @toonijn we need a test for this. I would start with the file where you observed the problem (probably the dataset can be shortened). If you need help, please let me know.

toonijn commented 1 year ago

No problem!

I've added a test with a small part of the file where it went wrong.

jankoslavic commented 1 year ago

Thanks! I have made a double check. Everything looks fine for me. Thank you @toonijn !!!