search

ladislas / Bare-Arduino-Project

Start your Arduino projects right out of the box
MIT License
565 stars 68 forks source link

fix: use branch auto-lib for Arduino-Makefile #58

Closed m-dhooge closed 4 years ago

m-dhooge commented 4 years ago

Hello, The Arduino-Makefile submodule configuration points to #8c8ebf71a0b7 which is on no branches and is thus not retrieved when doing the git submodule update. From what I see, it is strictly equivalent to the top of branch auto-lib. I also changed `.gitmodules' to point to the new repository. M.

m-dhooge commented 4 years ago

Well, not exactly… I started from https://github.com/leka/Arduino-Makefile/commit/8c8ebf71a0b7c7095038eff49153c308daec1ff9 and went up twice to reach the master branch. I thought it was the top of the branch. But in fact, it is at https://github.com/leka/Arduino-Makefile/commit/591855b8904bcff14c7c7f127653186a0b482360 So I guess we're still good… but it isn't strictly equivalent.

hoijui commented 4 years ago

+1 on this; please merge.

ladislas commented 4 years ago

Thanks for the PR @m-dhooge -- I've now fixed the issue :)