search

ladjs / react-native-loading-spinner-overlay

:barber: React Native loading spinner overlay
MIT License
1.59k stars 173 forks source link

Issue #27 - add support for custom spinner gif #34

Closed b8ne closed 7 years ago

b8ne commented 7 years ago

Hey @niftylettuce ive implemented this. All works fine, the only issue I had was the spinner 'key'. Because it referenced date.now() the gif kept flashing. I changed it to a constant which fixed it, and the native indicator still works. Its a little bit beyond my current knowledge so let me know if there was a reason for this and ill fix it. Cheers

niftylettuce commented 7 years ago

whats the status on this? does this PR need updated?

b8ne commented 7 years ago

Hey mate it builds and works fine. So if you're happy with it then merge it. Just mentioned that incase i missed the reasoning behind that key.

SandroMachado commented 7 years ago

I think this was deprecated by #37. This can be closed. @niftylettuce WDYT?

niftylettuce commented 7 years ago

Correct, you can add a custom spinner now via:

<Spinner visible={this.state.visible}>
  <Text>This is my custom spinner</Text>
</Spinner>