search

ladjs / react-native-loading-spinner-overlay

:barber: React Native loading spinner overlay
MIT License
1.58k stars 173 forks source link

Issue #45: support for preventing spinner from hiding on Android back #46

Closed gsavvid closed 7 years ago

gsavvid commented 7 years ago

On Android there's the need of preventing spinner from hiding when pressing the hardware back button. This can be resolved by setting the new prop cancelable to false -by default it's true.

This has no effect on iOS as the Modal's onRequestClose prop is Android-specific.

niftylettuce commented 7 years ago

@SandroMachado did you want to version bump and release new version to NPM? I can if you need, thanks - just let me know. 🎉

SandroMachado commented 7 years ago

@niftylettuce if you have time, please do it. I can only do the release later today.

niftylettuce commented 7 years ago

released 0.4.3

niftylettuce commented 7 years ago

I unpublished 0.4.3 - I have published 0.4.4 with a default of false for cancelable. The intent of this loading spinner is to prevent a user from being able to do any other action in the app while it is loading. Even though this is a breaking change, on iOS (the platform that is the standard base) doesn't allow it to hide. See 0.4.4.