Closed charlenetshos closed 4 years ago
Hello @niftylettuce! We're quite keen to see this fixed as we're having a number of socket timeout errors. I'm wondering when you'll have an opportunity to review this PR. Is there something I can do to make it happen? Thank you
v5.3.0 published to npm and GitHub releases page with changelog
@niftylettuce thank you for releasing this!
no prob
~Just so you're aware, I had to revert this because the tests failed.~
Oh sorry, I commented on the wrong issue. Ignore this.
For reference, or if you want to help debug, see https://github.com/visionmedia/superagent/pull/1527.
This PR is to enforce consistent
retry
behaviour for both the.end
and.then
syntaxes.The problem I'm trying to fix has been highlighted in these issues:
When using
.then
syntax in Node.js, we only want to abort a request if there are no retries or the maximum number of retries has been exceeded.Please review