search

ladjs / superagent

Ajax for Node.js and browsers (JS HTTP client). Maintained for @forwardemail, @ladjs, @spamscanner, @breejs, @cabinjs, and @lassjs.
https://ladjs.github.io/superagent/
MIT License
16.58k stars 1.33k forks source link

Extend .npmignore with few extra things which do not need to be published #1593

Closed pkuczynski closed 2 years ago

pkuczynski commented 3 years ago

The smaller the package the faster the download :)

pkuczynski commented 3 years ago

@niftylettuce any feedback on this PR?

niftylettuce commented 3 years ago

Could we just make this mirrored to the .gitignore of projects like https://github.com/cabinjs/cabin or https://github.com/ladjs/lad? I think there's too much bloat in here.

pkuczynski commented 3 years ago

@niftylettuce sure. Here you go: https://github.com/cabinjs/cabin/pull/147 https://github.com/ladjs/lad/pull/418

pkuczynski commented 3 years ago

@niftylettuce how about this PR? Can you approve it and merge it?

niftylettuce commented 3 years ago

yarn.lock should be committed to the repo

pkuczynski commented 3 years ago

This is about .npmignore not .gitignore. So after this PR is merged, yarn.lock will be still committable, but not published to npm. Make sense?

niftylettuce commented 2 years ago

Closed in favor of https://github.com/visionmedia/superagent/pull/1667