search

ladjs / superagent

Ajax for Node.js and browsers (JS HTTP client). Maintained for @forwardemail, @ladjs, @spamscanner, @breejs, @cabinjs, and @lassjs.
https://ladjs.github.io/superagent/
MIT License
16.58k stars 1.33k forks source link

formidable warnings when used with webpack #1609

Closed byungjuJin closed 2 years ago

byungjuJin commented 3 years ago

in dependencies, superagent use "formidable": "^1.2.2" And this have a issue with webpack. For fix it, update need to formidable V2. It still on canary version but owner recommend use it. Please check below issue.

https://github.com/node-formidable/formidable/issues/337

Warning: ./node_modules/superagent/node_modules/formidable/lib/incoming_form.js 1:43-50 Critical dependency: require function is used in a way in which dependencies cannot be statically extracted at CommonJsRequireContextDependency.getWarnings () @ ./node_modules/superagent/node_modules/formidable/lib/index.js @ ./node_modules/superagent/lib/node/index.js

mccart commented 2 years ago

formidable v1 now depreciated and v2 supposed to be backward compatible to v1

vicb commented 2 years ago

Hey @niftylettuce is this fixed in 7.0.1 ? I see that formidable is now at v2.

If not is there anything I can help with ?

niftylettuce commented 2 years ago

Yeah it's fixed, thank you!