search

ladjs / superagent

Ajax for Node.js and browsers (JS HTTP client). Maintained for @forwardemail, @ladjs, @spamscanner, @breejs, @cabinjs, and @lassjs.
https://ladjs.github.io/superagent/
MIT License
16.58k stars 1.33k forks source link

Use a single .browserslistrc file and babel.config.js #1633

Closed pravi closed 2 years ago

pravi commented 3 years ago

Currently we use two different non standard .babelrc configuration files and browserslist entries are duplicated in 3 files. This MR consolidates all browsers list entries to a single file and use BROWSERSLIST_ENV variable to switch between lib and dist targets.

niftylettuce commented 2 years ago

Very cool, didn't know you could do this. Can you fix the conflicts and then I'll merge?

titanism commented 2 years ago

Thank you for this PR, however there have been a few changes since review.

Please submit a new PR with conflicts resolved and one that also supports the test babelrc config.

Also the file name of babel.config.js is preferred over babel.config.json.