ladjs / superagent

Ajax for Node.js and browsers (JS HTTP client). Maintained for @forwardemail, @ladjs, @spamscanner, @breejs, @cabinjs, and @lassjs.
https://ladjs.github.io/superagent/
MIT License
16.58k stars 1.33k forks source link

Unable to install 7.0.1 version on 16.12.0 Node #1665

Closed brainroma closed 2 years ago

brainroma commented 2 years ago

Still getting the error when trying to install 7.0.1 version on v16 Node

npm ERR! code EBADENGINE npm ERR! engine Unsupported engine npm ERR! engine Not compatible with your version of node/npm: superagent@7.0.1 npm ERR! notsup Not compatible with your version of node/npm: superagent@7.0.1 npm ERR! notsup Required: {"node":">=6.4.0 !13"} npm ERR! notsup Actual: {"npm":"8.3.0","node":"v16.12.0"}

korbav commented 2 years ago

https://github.com/visionmedia/supertest/issues/752#issuecomment-1009854158

Please replace >=6.4.0 !13 by 6.4.0 - 12 || >= 14

SergioSuarezDev commented 2 years ago

same here

npm ERR! code EBADENGINE
npm ERR! engine Unsupported engine
npm ERR! engine Not compatible with your version of node/npm: superagent@7.0.1
npm ERR! notsup Not compatible with your version of node/npm: superagent@7.0.1
npm ERR! notsup Required: {"node":">=6.4.0 !13"}
npm ERR! notsup Actual:   {"npm":"8.3.0","node":"v14.18.1"}

My node v: v14.18.1 My npm v: 8.3.0

visoft commented 2 years ago

No error, but a warning

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'superagent@7.0.1',
npm WARN EBADENGINE   required: { node: '>=6.4.0 !13' },
npm WARN EBADENGINE   current: { node: 'v16.13.1', npm: '8.1.2' }
npm WARN EBADENGINE }
ekmobile commented 2 years ago

For me it's an error:

npm i --save-dev supertest

npm ERR! code ENOTSUP npm ERR! notsup Unsupported engine for superagent@7.0.1: wanted: {"node":">=6.4.0 !13"} (current: {"node":"14.18.2","npm":"6.14.15"}) npm ERR! notsup Not compatible with your version of node/npm: superagent@7.0.1 npm ERR! notsup Not compatible with your version of node/npm: superagent@7.0.1 npm ERR! notsup Required: {"node":">=6.4.0 !13"} npm ERR! notsup Actual: {"npm":"6.14.15","node":"14.18.2"}

Morl99 commented 2 years ago

The error appears, if npm is configured to use engine-strict, which is not a bad idea, so this needs to be fixed, because it breaks all pipelines that have engine-strict enabled.

SergioSuarezDev commented 2 years ago

In my case the error comes from the nestjs framework that uses superset https://github.com/nestjs/nest/blob/master/package.json

glasser commented 2 years ago

I've filed https://github.com/visionmedia/superagent/pull/1666 to fix this issue. (It is more correct than #1663 which fails to exclude v13.)

niftylettuce commented 2 years ago

v7.0.2 released https://github.com/visionmedia/superagent/releases/tag/v7.0.2

I had to publish with np --no-tests because of yarn test lint errors with eslint not parsing engines properly per https://github.com/mysticatea/eslint-plugin-node/issues/315.