search

ladjs / superagent

Ajax for Node.js and browsers (JS HTTP client). Maintained for @forwardemail, @ladjs, @spamscanner, @breejs, @cabinjs, and @lassjs.
https://ladjs.github.io/superagent/
MIT License
16.58k stars 1.33k forks source link

package.json: fix invalid syntax in `engines` #1666

Closed glasser closed 2 years ago

glasser commented 2 years ago

! is not supported by the semver library. This fixes a regression in v7 when used with engine-strict mode.

While the change in this PR may look similar to the state before #1660, it differs by using two pipe characters instead of one.

Fixes #1665.

jcurlier commented 2 years ago

+1

niftylettuce commented 2 years ago

v7.0.2 released https://github.com/visionmedia/superagent/releases/tag/v7.0.2

I had to publish with np --no-tests because of yarn test lint errors with eslint not parsing engines properly per https://github.com/mysticatea/eslint-plugin-node/issues/315.

glasser commented 2 years ago

Thank you!