Closed jimmywarting closed 2 years ago
There's no reason why we shouldn't support older versions especially with the help of Babel.
I turned most of those lint errors to warnings via rules override, and for the ones you shared that are node/no-unsupported-features/es-syntax
, it is due to the linter not respecting engines
having multiple versions specified (obviously it's a bug).
Ref: https://github.com/mysticatea/eslint-plugin-node/issues/315
couldn't we disabled the node/no-unsupported-features/es-syntax
rule then if babel takes care of compiling any new es feature we may use then?
I tried to disable that rule but it didn't work for me when I tried. Not sure if you want to go down that rabbit hole.
The linting and newest version of xo on a old codebase is a little... meh it clearly have fallen behind in the amount of things it yields about.
One of the thing i settled on was the features we use, and the targeted node.js version.
what do you say about setting it to something more modern like >=12 ? v12 is ending it's long time support pretty soon now in April