ladjs / superagent

Ajax for Node.js and browsers (JS HTTP client). Maintained for @forwardemail, @ladjs, @spamscanner, @breejs, @cabinjs, and @lassjs.
https://ladjs.github.io/superagent/
MIT License
16.58k stars 1.33k forks source link

fix: fixed the errors of eslint #1675

Closed yunnysunny closed 2 years ago

yunnysunny commented 2 years ago

Superagent has three eslint configuration files. The .lib.eslintrc to valid the files under the directory of lib , the .dist.eslintrc to valid the files under the direcotry of dist, the property of xo of package.json to valid all the project's file.

For the issue of https://github.com/xojs/xo/issues/598 from xo ,we can not disable the rule for low version node check, such as the rule node/no-unsupported-features/node-builtins. So I just switch to use the native eslint, and add a new configuration file, named .eslintrc. This will also benefit for the vscode, when use the file .eslintrc , vscode can use the rules from it.

For current project not install the eslint plugin of eslint-plugin-unicorn in package.json. So I have not set it as an extendtion to .eslintrc. Someone can install it manual and use the rules from it after the pull request is merged.