search

ladjs / superagent

Ajax for Node.js and browsers (JS HTTP client). Maintained for @forwardemail, @ladjs, @spamscanner, @breejs, @cabinjs, and @lassjs.
https://ladjs.github.io/superagent/
MIT License
16.56k stars 1.33k forks source link

Optional dependencies are dev dependencies #1728

Closed perrin4869 closed 2 years ago

perrin4869 commented 2 years ago

Reverts https://github.com/visionmedia/superagent/pull/1722 On version 7.1.4 my project's CI is pulling down all the superagent optional dependencies by default, and it is breaking my CI. Those dependencies are really dev dependencies, not optional dependencies.

titanism commented 2 years ago

Agreed

titanism commented 2 years ago

v7.1.5 released to npm (note the tests are broken until someone rewrites them)

https://github.com/visionmedia/superagent/releases/tag/v7.1.5