search

ladjs / superagent

Ajax for Node.js and browsers (JS HTTP client). Maintained for @forwardemail, @ladjs, @spamscanner, @breejs, @cabinjs, and @lassjs.
https://ladjs.github.io/superagent/
MIT License
16.56k stars 1.33k forks source link

Re-enable the test for old Node #1729

Closed yunnysunny closed 2 years ago

yunnysunny commented 2 years ago
  1. pre-commit use yarn lint-staged to check code validation, but it can not read configration of eslint properly. And yarn test include the npm script of lint. So I remove the yarn lint-staged from pre-commit.
  2. The lint script will fail to run in pre-commit on Windows, so I correct it.
  3. Re-enable the test for old Node by rewriting the package.json in CI.
  4. Rollback the dependencies of commitlint and husky to old version to make it run OK on Node 12.
codecov-commenter commented 2 years ago

Codecov Report

Merging #1729 (18896ec) into master (3b1ff63) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1729      +/-   ##
==========================================
+ Coverage   94.09%   94.10%   +0.01%     
==========================================
  Files          14       14              
  Lines        1134     1137       +3     
==========================================
+ Hits         1067     1070       +3     
  Misses         67       67
Impacted Files Coverage Δ
src/request-base.js 93.06% <ø> (ø)
src/node/index.js 93.66% <100.00%> (+0.02%) :arrow_up:
src/node/parsers/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4f043a8...18896ec. Read the comment docs.