search

ladjs / superagent

Ajax for Node.js and browsers (JS HTTP client). Maintained for @forwardemail, @ladjs, @spamscanner, @breejs, @cabinjs, and @lassjs.
https://ladjs.github.io/superagent/
MIT License
16.58k stars 1.33k forks source link

Update tinyify to 4.x #1747

Closed lorand-horvath closed 1 year ago

lorand-horvath commented 1 year ago

Should fix https://github.com/visionmedia/superagent/issues/1743

titanism commented 1 year ago

I've tested and this doesn't seem to fix the issue. I'm still trying to investigate and see what's wrong. Help is welcome.

titanism commented 1 year ago

Ah- I found the culprit - it's the minify npm script which is causing the issue. So most likely browserify/tinyify are the culprits as we suspect. I'm going to try version locking and such and see if that resolves.

titanism commented 1 year ago

This is related to https://github.com/browserify/common-shakeify/issues/41 and https://github.com/browserify/common-shakeify/issues/42

titanism commented 1 year ago

v8.0.3 released to npm 🎉 !!

the issue was tinyify, which bumped common-shakeify, and has a few underlying issues that need resolved before we can upgrade it. apologies for the delay, this wasn't easy to track down.

https://github.com/visionmedia/superagent/releases/tag/v8.0.3

titanism commented 1 year ago

To anyone reading, tinyify still seems to have issues on 4.x and > 3.0.0 versions. If anyone wants to dig in, please do so.