ladjs / superagent

Ajax for Node.js and browsers (JS HTTP client). Maintained for @forwardemail, @ladjs, @spamscanner, @breejs, @cabinjs, and @lassjs.
https://ladjs.github.io/superagent/
MIT License
16.56k stars 1.33k forks source link

ci: fixed broken ci #1753

Closed lamweili closed 1 year ago

lamweili commented 1 year ago

fixed ci failing due to incompatible dev dependencies for Node.js <=12

codecov-commenter commented 1 year ago

Codecov Report

Merging #1753 (889e90c) into master (0769a85) will increase coverage by 0.06%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1753      +/-   ##
==========================================
+ Coverage   94.36%   94.42%   +0.06%     
==========================================
  Files          14       14              
  Lines        1135     1148      +13     
==========================================
+ Hits         1071     1084      +13     
  Misses         64       64              
Impacted Files Coverage Δ
src/request-base.js 93.06% <ø> (ø)
src/agent-base.js 100.00% <0.00%> (ø)
src/node/index.js 93.69% <0.00%> (+0.02%) :arrow_up:
src/utils.js 97.36% <0.00%> (+0.14%) :arrow_up:
src/node/http2wrapper.js 96.46% <0.00%> (+0.19%) :arrow_up:
src/node/agent.js 89.13% <0.00%> (+0.49%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

lamweili commented 1 year ago

@titanism, this would fix the broken ci tests by downgrading the mocha. It is fine because it's a dev dependency anyway.

No release is needed as this doesn't affect the code.