ladjs / superagent

Ajax for Node.js and browsers (JS HTTP client). Maintained for @forwardemail, @ladjs, @spamscanner, @breejs, @cabinjs, and @lassjs.
https://ladjs.github.io/superagent/
MIT License
16.57k stars 1.33k forks source link

chore: classify agent #1777

Closed jimmywarting closed 10 months ago

jimmywarting commented 10 months ago

Checklist

hoping to have some more modernized codebase with classes and better IDE/autosuggestions. some wishful thinking is also to be able to use private class method/fields later on.

codecov-commenter commented 10 months ago

Codecov Report

Patch coverage: 87.50% and project coverage change: -0.01% :warning:

Comparison is base (cfb7b5e) 94.40% compared to head (fca95a3) 94.39%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1777 +/- ## ========================================== - Coverage 94.40% 94.39% -0.01% ========================================== Files 14 14 Lines 1143 1141 -2 ========================================== - Hits 1079 1077 -2 Misses 64 64 ``` | [Files Changed](https://app.codecov.io/gh/ladjs/superagent/pull/1777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ladjs) | Coverage Δ | | |---|---|---| | [src/node/agent.js](https://app.codecov.io/gh/ladjs/superagent/pull/1777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ladjs#diff-c3JjL25vZGUvYWdlbnQuanM=) | `88.88% <84.00%> (-0.70%)` | :arrow_down: | | [src/agent-base.js](https://app.codecov.io/gh/ladjs/superagent/pull/1777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ladjs#diff-c3JjL2FnZW50LWJhc2UuanM=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

titanism commented 10 months ago

awesome work - let us know when ready for review. happy to have you as a collab/maintainer too on all of this

jimmywarting commented 10 months ago

Thanks. I'm ready for a review. I just did a simple PR to see if this is active/maintained and what kind of things you are acceptable of. you can maybe expect more PR to come later on.