[proposal] Only using node testing tools

ladjs / superagent

Ajax for Node.js and browsers (JS HTTP client). Maintained for @forwardemail, @ladjs, @spamscanner, @breejs, @cabinjs, and @lassjs.

https://ladjs.github.io/superagent/

MIT License

16.58k stars 1.33k forks source link

[proposal] Only using node testing tools #1779

Open jimmywarting opened 1 year ago

jimmywarting commented 1 year ago

Describe the feature

I would like (if you agree) to refactor the spec/test to only using node:assert and possible get rid of any outdated dependency.

Checklist

[x] I have searched through GitHub issues for similar issues.
[x] I have completely read through the README and documentation.

jimmywarting commented 1 year ago

I have not been such a huge fan of things such as res.text.should.equal('{"name":"hal 5000"}');

should pollutes global built in prototypes chain with things you believe are part of the package when it is in fact not.

titanism commented 1 year ago

Definitely down to use built-in Node test stuff, either that or Ava like we did with https://github.com/breejs/bree

jimmywarting commented 1 year ago

I prefer dependency free stuff. now that NodeJS have also a built in test runner also node:test and also a node:assert, then i have stop installing any additional dependencies.

the latest version of node testing tools have really grown to be something 👌