ladybug-tools / butterfly-plus

Butterfly[+] plugins...
GNU General Public License v3.0
13 stars 11 forks source link

Parameter order in recipe components is wrong #8

Open H-Tsubota opened 4 years ago

H-Tsubota commented 4 years ago

I use butterfly (ver 0.0.05 (JAN_12_2019)) on Rhinoceros6 Grasshopper. And I found that constructor's parameter order in recipe component may be wrong.

SteadyIncompressible and HeatTransfer is created in recipe component (UserObject) as following.

In "Butterfly_Steady Incompressible Recipe" component :

recipe = SteadyIncompressible(_turbulence_prop_, fv_schemes_, fv_solution_,
                              residual_control_, _relaxation_factors_)

In "Butterfly_Heat Transfer Recipe" component :

recipe = HeatTransfer(_turbulence_prop_, fv_schemes_, fv_solution_, residual_control_,
                      _relaxation_factors_, TRef=_temperature_)

But each class constructor are defined in "butterfly\recipe.py" as following.

class SteadyIncompressible(_SingleCommandRecipe):
    ...
    def __init__(self, turbulenceProperties=None, fvSolution=None,
                 fvSchemes=None, residualControl=None, relaxationFactors=None):
class HeatTransfer(_SingleCommandRecipe):
    ...
    def __init__(self, turbulenceProperties=None, fvSolution=None,
                 fvSchemes=None, residualControl=None, relaxationFactors=None,
                 TRef=None):

So I believe that fvschemes and fvsolution must be reversed in recipe component .