ladybug-tools / butterfly

:butterfly: A light python API for creating and running OpenFoam cases for CFD simulation.
http://ladybug-tools.github.io/butterfly.html
GNU General Public License v3.0
249 stars 71 forks source link

"Butterfly_Load Mesh" component #151

Closed thinklikeanarchitect closed 7 years ago

thinklikeanarchitect commented 7 years ago

For a very basic case, you get at least 30000 faces, its not very high to visualise with grasshopper, however, when you use lets say 1m mesh cell size for xyz, then it takes too much time to visualise mesh. So I have edited this component( BF load mesh comp). Actually, it would be perfect for larger cases, also even in a complex case with higher mesh settings! It means %600 speed up even for a simple case!

I will send a pull request when I finished editing @mostaphaRoudsari

saket411 commented 7 years ago

@mimarilker The visualize mesh component would freeze my gh if the no. of cells are more than 1m. Being a beginner many times its helpful for me to visualize to confirm the grading esp. Thanks!! I look forward to test it.

thinklikeanarchitect commented 7 years ago

Actually, @ Mostapha will try to find a workaround for this.

mostaphaRoudsari commented 7 years ago

@mimarilker, @saket411 seems there is an easier way for doing this by using boundary file under polyMesh folder. In this file you can find face numbers for each boundary geometry and just load them without loading the InnerMesh. We should add a new parameter to utilities.loadOFFacesFile for this: https://github.com/ladybug-analysis-tools/butterfly/blob/182a793b1945058e515a86eeccc9b332dcba0b4a/butterfly/utilities.py#L308

thinklikeanarchitect commented 7 years ago

excellent new development than!

mostaphaRoudsari commented 7 years ago

image

thinklikeanarchitect commented 7 years ago

I have updated BF to load new component, it has come, however now blockmesh comp. is missing and the newer version of load mesh comp. gives error. I just linked the blockMesh case output with it and connected a boolean to load it. Thats it.

You can regenerate same error with trying it on outdoor_airflow case.

  1. Solution exception:loadMesh() takes exactly 1 argument (2 given)

Edit: Its working with the new sample file, I didnt know why. I think I updated BF in a wrong time, I mean when some components were being changed:)

Btw its excellent, thanks a lot, it works nearly 2x faster even in a simple case!

mostaphaRoudsari commented 7 years ago

@mimarilker thanks. the reason it didn't work first time after the update is that Rhino caches the python libraries after import, so to load the new library after the update you need to close both Rhino and Grasshopper.

ladybugbot commented 5 years ago

:tada: This issue has been resolved in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: