ladybug-tools / butterfly

:butterfly: A light python API for creating and running OpenFoam cases for CFD simulation.
http://ladybug-tools.github.io/butterfly.html
GNU General Public License v3.0
249 stars 71 forks source link

refWindHeight input not reflecting in ABL conditions #229

Open DambronOlivier opened 7 years ago

DambronOlivier commented 7 years ago

Dear @mostaphaRoudsari ,

I have been running a case with a terrain, of which the highest point is at 48 m on the z axis. Therefore I have tried to set the refwindheight to 58m (48+10) and I found that the ABL conditions inside /0 were accounting for Zref = 10m. Could you confirm if this is a bug?

2

Kind regards, Olivier

TheodoreGalanos commented 7 years ago

Hi @DambronOlivier Let us look into this, might be a bug yes. Are you sure you re-wrote the case in the run component? That's when the ABLConditions file will get updated.

Also, you don't need to set Zref at 58m. Follow the true heights. Set your minimum z in the ABL file accordingly (from what I see is 0) and then the refHeight as it is (10m). OF will do the rest.

Kind regards, Theodore.

mostaphaRoudsari commented 7 years ago

Hi @DambronOlivier,

What @TheodoreGalanos said is right.

  1. Solution component is the one that writes/updates 0 folder files. Create Case components write minimum data that is needed for meshing. If you create the case and then write the solution we will know if it is a bug.
  2. refWindHeight is the reference heights for wind speed input. It's usually 10m if you use the wind speed from a weather file, otherwise you have to set it to the height that the input wind speed is measured.
DambronOlivier commented 7 years ago

Hi @TheodoreGalanos and @mostaphaRoudsari ,

Many thanks for your replies.

  1. Forgive me for not having been very clear. I have indeed created the case and written the solution with the solution component. The Zref is not modified accordingly as depicted in the capture I posted initially.

  2. If I understand correctly, the min z is the zGround in the ABL file. Would it be possible to consider in the next phase of updates, adding an input to the wind tunnel component to set it or do you feel it should be set through the solution paramaters component?

Kind regards,

Olivier

eeshakhanna1 commented 4 years ago

Hi @DambronOlivier - I am trying to figure out how to integrate terrain into my BF outdoor wind analysis. Where did you add your terrain in the script? Was it part of the BF geometry? Or did you create a custom wind tunnel with the terrain at the bottom? I am a little confused about what the best method is. Any input would be helpful, thanks!