search

ladybug-tools / dragonfly-doe2

:dragon: :tokyo_tower: Dragonfly extension for energy simulation with DOE2
https://www.ladybug.tools/dragonfly-doe2/docs/
GNU Affero General Public License v3.0
3 stars 5 forks source link

Add zn spc #7

Closed TfedUD closed 2 years ago

TfedUD commented 2 years ago

There are still a couple things that need to get taken care of for 3d geom viz: some of the construction/layers etc naming conventions are missing a nomen thing for proper referencing, also I think that I may be doubling up on the unit conversion as the dfm.json units are 'feet'; going to double check and handle for next PR.

But: has floor/space/wall block inputs now!

mostaphaRoudsari commented 2 years ago

Hi @TfedUD,

Good point. We enforce a unit translation here: https://github.com/ladybug-tools/dragonfly-doe2/blob/389620bdb9301a64b282c30e62f47980415d15ff/dragonfly_doe2/writer.py#L21

We should probably move it inside the Doe Model object to ensure all the input models are translated to feet and then document the expectations there for the input model.

I don't know if this transition also updates the construction/material units but it does update the geometry units for sure!

TfedUD commented 2 years ago

Hi @TfedUD,

Good point. We enforce a unit translation here:

https://github.com/ladybug-tools/dragonfly-doe2/blob/389620bdb9301a64b282c30e62f47980415d15ff/dragonfly_doe2/writer.py#L21

We should probably move it inside the Doe Model object to ensure all the input models are translated to feet and then document the expectations there for the input model.

I don't know if this transition also updates the construction/material units but it does update the geometry units for sure!

Am going to address this in the next round of 'make 3D work' work & resulting PR!

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 0.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: