search

ladybug-tools / dragonfly-legacy

:bug: Legacy dragonfly plugin for large-scale climate and urban heat island modeling.
Other
42 stars 14 forks source link

Revising 'UWG' to 'uwg' #36

Closed saeranv closed 6 years ago

saeranv commented 6 years ago

@chriswmackey

I admit this is a messy commit (blank lines being shown in the diff), so feel free to salvage what you can and throw the rest away if you feel like it. Underneath the weird diff though, this should be a working, updated Dragonfly repo. Specifically, I've changed all the UWG and Dragonfly source code, the installer.gh file, and associated user objects with the new 'uwg' naming convention. I've tested out the new components with the examples files on Hydra, and everything seems to be working well.

The one thing that's giving me issues is that the 'update Dragonfly' component doesn't seem to pull the correct userobjects for the newly updated components. For the purposes of testing, I made sure to modify this component to pull it's files from my local git repo where I have all the modified src code and userobjects, but it's still updating with the old components. I had to manually add everything from the GH toolbar to actually test the files. Youll probably have a better idea of what's going wrong here.

Let me know how it looks, and if you want any changes made.

S

chriswmackey commented 6 years ago

Looks good @saeranv . I see that running the code through autopep8 cleaned up a lot of unnecessary blank lines. Thanks for doing this!