search

ladybug-tools / dragonfly-legacy

:bug: Legacy dragonfly plugin for large-scale climate and urban heat island modeling.
Other
42 stars 14 forks source link

DF needs to add floor height parameter to BEM.building not BEM #46

Closed saeranv closed 6 years ago

saeranv commented 6 years ago

@chriswmackey

In the Run UWG component, the floorHeight parameter is being incorrectly assigned to the BEM object, it should be assigned to the building object. https://github.com/chriswmackey/Dragonfly/blob/220e5c11de084b9963cb28d0fe278b74e68e59a1/src/DF%20Run%20Urban%20Weather%20Generator.py#L195

i.e uwg_typology.building.floorHeight = df_typology.floor_to_floor

I vaguely feel like Anna found this mistake at some point, and we just never got around to correcting it. At any rate, noting it here so we make sure to address this.

chriswmackey commented 6 years ago

Thanks for finding this one @saeranv and @annasong20 !

I have fixed this both in the legacy plugin here: https://github.com/chriswmackey/Dragonfly/commit/2b58ac695423e4feb3e438222ef026437c60a295

... and in the core library: https://github.com/ladybug-tools/dragonfly/commit/9dce11a09d71d81e3ae9879bc43818c69a2d740e