style(room): Ensure faces_by_guide_surface works with concave faces

ladybug-tools / honeybee-core

:honeybee: honeybee core library

https://www.ladybug.tools/honeybee-core/docs/

GNU Affero General Public License v3.0

17 stars 15 forks source link

style(room): Ensure faces_by_guide_surface works with concave faces #436

Closed chriswmackey closed 3 years ago

chriswmackey commented 3 years ago

I realized that the method might not be so reliable for concave faces where the center point lies outside of the face boundary.

So I am changing it to use the exact ladybug_geometry method that gets called in the solve adjacency method, which ensure that we always get a point that is on the face.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.44.15 :tada:

The release is available on:

GitHub release
v1.44.15

Your semantic-release bot :package::rocket: